read data from an hdf rather than a csv #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmudambi
requested review from
albrja,
hussain-jafari,
mattkappel,
ramittal and
stevebachmeier
as code owners
| column.loc[to_noise_idx], configuration, randomness_stream, additional_key | ||
| ) | ||
|
|
||
| column.loc[to_noise_idx] = noised_data |
There was a problem hiding this comment.
Was this actually causing a problem or do you just find this more readable?
There was a problem hiding this comment.
This just made debugging easier since I could put a breakpoint between the function call and the assignment to the series.
src/pseudopeople/interface.py
Outdated
| data = pd.read_csv(path, dtype=str, keep_default_na=False) | ||
| data = pd.read_hdf(path) | ||
| if not isinstance(data, pd.DataFrame): | ||
| raise TypeError(f"File located at {path} must contain a pandas DataFrame.") |
There was a problem hiding this comment.
Consider moving into a load_data utility function so that we don't forget to check type.
| @@ -303,6 +303,7 @@ def keyboard_corrupt(truth, corrupted_pr, addl_pr, rng): | |||
| include_original_token_level = configuration.include_original_token_level | |||
|
|
|||
| rng = np.random.default_rng(seed=randomness_stream.seed) | |||
| column = column.astype(str) | |||
There was a problem hiding this comment.
This will convert any NaNs to "nan" and proceed to corrupt that. We shouldn't have any NaNs at this point though, right? B/c those get dropped up front when this gets called?
There was a problem hiding this comment.
Yes, that's correct, but definitely great to call this out
stevebachmeier
approved these changes
Apr 4, 2023
albrja
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read data from HDF rather than CSV
Description
Read data in from HDF rather than CSV
Fix errors in
incorrect_select_options.csvFix issue with categorical dtypes by using NA instead of "" for missing data
Cast column to str dtype for typographic errors.
Testing
Ran integration tests against sample data generated by the updated simulation which outputs hdfs.
Ran automated test suite